Skip to content

Repository Dispatch: improve error message for fork PRs #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2022
Merged

Repository Dispatch: improve error message for fork PRs #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da17d70
Add error message for repository dispatch action
AgnesToulet Jun 2, 2022
e7614db
upgrade other TS deps
AgnesToulet Jun 2, 2022
6eb2a6c
clean up
AgnesToulet Jun 2, 2022
6650d6c
apply review feedback
AgnesToulet Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion common/globmatcher.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion common/utils.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
"@types/jest": "^27.4.0",
"@types/node": "^14.14.7",
"@types/yargs": "^15.0.4",
"@typescript-eslint/eslint-plugin": "^5.6.0",
"@typescript-eslint/parser": "^5.6.0",
"@typescript-eslint/eslint-plugin": "^5.27.0",
"@typescript-eslint/parser": "^5.27.0",
"chai": "^4.2.0",
"eslint": "^8.4.1",
"eslint-config-prettier": "^8.3.0",
Expand All @@ -54,7 +54,7 @@
"prettier": "2.5.1",
"ts-jest": "^27.1.3",
"ts-node": "^8.10.2",
"typescript": "^4.5.2",
"typescript": "^4.7.2",
"yargs": "^15.3.1"
},
"husky": {
Expand Down
7 changes: 6 additions & 1 deletion repository-dispatch/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 13 additions & 1 deletion repository-dispatch/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,25 @@ import { getInput } from '@actions/core'
class RepositoryDispatch extends Action {
id = 'RepositoryDispatch'

constructor() {
const token = getInput('token')
const eventType = getInput('event_type')
if (!token && eventType === 'oss-pull-request') {
console.log(
"Token is empty, can't dispatch event. This is expected for PRs coming from forks, please check that the changes are compatible with Enterprise before merging this PR.",
)
}

super()
}

async runAction(): Promise<void> {
const repository = getInput('repository')
if (!repository) {
throw new Error('Missing repository')
}

const api = new OctoKit(this.getToken(), context.repo)
const api = new OctoKit(this.getToken(), context.repo)

const [owner, repo] = repository.split('/')

Expand Down
Loading