Skip to content
This repository was archived by the owner on Dec 3, 2025. It is now read-only.

Conversation

@bamboo
Copy link
Member

@bamboo bamboo commented Jan 22, 2019

During the investigation of #1308, the following stack trace snippet appeared in the Kotlin DSL resolver log:

Caused by: org.gradle.api.UncheckedIOException: java.io.StreamCorruptedException: invalid type code: 61
			at org.gradle.internal.UncheckedException.throwAsUncheckedException(UncheckedException.java:61)
			at org.gradle.internal.UncheckedException.throwAsUncheckedException(UncheckedException.java:41)
			at org.gradle.tooling.internal.provider.serialization.PayloadSerializer.deserialize(PayloadSerializer.java:76)
			at org.gradle.tooling.internal.provider.ProviderConnection.run(ProviderConnection.java:194)
			at org.gradle.tooling.internal.provider.ProviderConnection.run(ProviderConnection.java:135)
			at org.gradle.tooling.internal.provider.DefaultConnection.getModel(DefaultConnection.java:193)

At the top of the stack trace it read:

at org.gradle.tooling.internal.consumer.ExceptionTransformer.transform(ExceptionTransformer.java:55)

Which prompted me to provide this PR as a quick fix to the problem pending some further investigation on its root cause.

In order to avoid serialization issues observed on Java 11.

Resolves #1308
@bamboo bamboo added this to the 1.1.2 milestone Jan 22, 2019
@bamboo bamboo self-assigned this Jan 22, 2019
@bamboo bamboo requested a review from eskatos January 22, 2019 22:44
eskatos
eskatos previously approved these changes Jan 23, 2019
Copy link
Member

@eskatos eskatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing exceptions by strings in TAPI model is a good move, we can’t control what exceptions will be thrown so we should not expect them all to be “tapi serializable” 👍 💯

@eskatos eskatos dismissed their stale review January 23, 2019 08:48

This needs more scrutiny before being merged

Copy link
Member

@eskatos eskatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with several versions of IJ, works perfectly

@eskatos eskatos merged commit 890b78e into develop Jan 23, 2019
@bamboo bamboo deleted the bamboo/replace-exceptions-by-strings-in-tapi-model branch February 4, 2019 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants