Introduce native-image-musl feature.
#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gradinac
approved these changes
Jan 21, 2022
src/features.ts
Outdated
| await tc.extractTar(muslDownloadPath, basePath) | ||
| const muslPath = join(basePath, muslName) | ||
| core.addPath(join(muslPath, 'bin')) | ||
| core.exportVariable('CC', join(muslPath, 'bin', 'gcc')) |
There was a problem hiding this comment.
I'm not very familiar with the github actions API, but could we unset CC after we compile and install zlib? As the variable is only needed to build zlib, we should be able to remove it afterwards
There was a problem hiding this comment.
Thanks for pointing that out! I've dropped the export of CC and added it to the zlib build commands instead.
fniephaus
force-pushed
the
dev
branch
3 times, most recently
from
9f85030 to
927fe11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
native-image-muslfeature, which allows setting up a musl build environment for static image building with GraalVM Native Image (as discussed at oracle/graal#4150 (comment)).