Allow GPUTexture where GPUTextureView is used #5228

beaufortfrancois · 2025-06-20T09:39:51Z

This PR adds GPUTexture support to the following attributes:

GPUBindingResource
GPURenderPassColorAttachment view
GPURenderPassColorAttachment resolveTarget
GPURenderPassDepthStencilAttachment view

It also updates parts of the WebGPU and WGSL specs that I've missed when adding GPUBuffer in GPUBindingResource with #5193

FIX #5215

…resource

github-actions · 2025-06-20T09:44:31Z

Previews, as seen when this build job started (b3898a4):
WebGPU _{webgpu.idl | Explainer | Correspondence Reference}
WGSL _{grammar.js | wgsl.lalr.txt}

toji

I missed last weeks meeting so I don't know if this was agreed upon behavior. Doesn't seem like the linked issue reached a resolution, at least.

Assuming that the group has agreed on this, though, the PR looks good. Just a couple of nits.

spec/index.bs

beaufortfrancois

@toji Thanks for the review! My understanding from past meeting notes is that it had reached consensus.

spec/index.bs

…resource

toji

Thanks for the updates! WebGPU spec LGTM, but would you mind getting someone from the WGSL side (like @dneto0) to approve the WGSL spec changes?

spec/index.bs

beaufortfrancois · 2025-07-02T05:52:40Z

@dneto0 Please review

wgsl/index.bs

spec/index.bs

wgsl/index.bs

toji

Kai's edits LGTM.

dneto0

LGTM. Thanks!

beaufortfrancois · 2025-07-04T15:35:24Z

@kainino0x Shall we update webgpu.h as well or is it only for Javascript?

kainino0x · 2025-07-07T18:31:29Z

@beaufortfrancois no, we'll do this only for Javascript. It's just an implicit .createView() and there's no issue if the C API user has to do that themselves.

toji · 2025-07-07T18:34:23Z

I'm happy to do the Blink change unless this is something you wanted to tackle, @beaufortfrancois?

beaufortfrancois · 2025-07-07T18:54:21Z

I already had one ;) Feel free to review https://chromium-review.googlesource.com/c/chromium/src/+/6656722

This PR reflects the following spec changes: - gpuweb/gpuweb#5228

Spec PR: gpuweb/gpuweb#5228 Change-Id: I260164692b6476bb298ec8ad23bf8d1696d68778 Bug: 425906323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6656722 Commit-Queue: Fr <[email protected]> Reviewed-by: Brandon Jones <[email protected]> Cr-Commit-Position: refs/heads/main@{#1484331}

…`s are allowed r=#webgpu-reviewers! gpuweb/cts#4407 gpuweb/gpuweb#5228

…`s are allowed r=#webgpu-reviewers! Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874). Differential Revision: https://phabricator.services.mozilla.com/D257054

…`s are allowed r=webgpu-reviewers,webidl,smaug,nical Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874). Differential Revision: https://phabricator.services.mozilla.com/D257054

gpuweb/gpuweb#5228 allows using GPUTexture instead of GPUTextureView in a number of places.

No functional changes since the object types are not strongly checked in the Wasm -> JS bridge.

beaufortfrancois added 2 commits June 20, 2025 11:29

Allow GPUTexture where GPUTextureView is used

fd16b5c

Merge branch 'main' of github.com:gpuweb/gpuweb into texture-binding-…

78413a3

…resource

beaufortfrancois mentioned this pull request Jun 24, 2025

Allow GPUTexture where GPUTextureView is used gpuweb/cts#4407

Merged

8 tasks

beaufortfrancois requested a review from toji June 25, 2025 13:39

toji reviewed Jun 25, 2025

View reviewed changes

spec/index.bs Outdated Show resolved Hide resolved

spec/index.bs Outdated Show resolved Hide resolved

spec/index.bs Outdated Show resolved Hide resolved

spec/index.bs Outdated Show resolved Hide resolved

Address @toji feedback

303e109

beaufortfrancois commented Jun 26, 2025

View reviewed changes

spec/index.bs Outdated Show resolved Hide resolved

spec/index.bs Outdated Show resolved Hide resolved

spec/index.bs Outdated Show resolved Hide resolved

spec/index.bs Outdated Show resolved Hide resolved

Merge branch 'main' of github.com:gpuweb/gpuweb into texture-binding-…

110c42b

…resource

toji approved these changes Jun 26, 2025

View reviewed changes

beaufortfrancois requested a review from dneto0 June 27, 2025 07:22

kainino0x reviewed Jun 28, 2025

View reviewed changes

spec/index.bs Outdated Show resolved Hide resolved

beaufortfrancois added 2 commits June 30, 2025 09:00

s/resolve texture view/get view for texture binding/g

c2e59da

s/get view for texture binding/get as texture view/g

121260a

kainino0x added the needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet label Jul 2, 2025

kainino0x approved these changes Jul 2, 2025

View reviewed changes

spec/index.bs Outdated Show resolved Hide resolved

spec/index.bs Outdated Show resolved Hide resolved

spec/index.bs Outdated Show resolved Hide resolved

Address feedback

08eb5e2

kainino0x added 3 commits July 2, 2025 09:56

buildfix

d3e2dbc

editing on GPUBindGroupLayoutEntry members

8056085

wgsl: remove redundant table of resource types, fix some links

b3898a4

kainino0x approved these changes Jul 2, 2025

View reviewed changes

wgsl/index.bs Outdated Show resolved Hide resolved

spec/index.bs Outdated Show resolved Hide resolved

wgsl/index.bs Show resolved Hide resolved

toji approved these changes Jul 2, 2025

View reviewed changes

dneto0 approved these changes Jul 3, 2025

View reviewed changes

dneto0 merged commit e93276a into gpuweb:main Jul 3, 2025
4 checks passed

beaufortfrancois mentioned this pull request Jul 4, 2025

Allow GPUTexture where GPUTextureView is used gpuweb/types#186

Merged

kainino0x pushed a commit to gpuweb/types that referenced this pull request Jul 7, 2025

Allow GPUTexture where GPUTextureView is used (#186)

5cbe48e

This PR reflects the following spec changes: - gpuweb/gpuweb#5228

beaufortfrancois mentioned this pull request Jul 10, 2025

Use texture shorthands instead of view when possible webgpu/webgpu-samples#521

Open

ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Jul 11, 2025

Bug ??????? - feat(webgpu): allow GPUTextures where `GPUTextureView…

05d67ea

…`s are allowed r=#webgpu-reviewers! gpuweb/cts#4407 gpuweb/gpuweb#5228

ErichDonGubler mentioned this pull request Jul 11, 2025

Allow Texture where TextureView is used gfx-rs/wgpu#7933

Closed

This comment was marked as spam.

Sign in to view

gpuweb deleted a comment from rezadzed Jul 13, 2025

beaufortfrancois mentioned this pull request Jul 17, 2025

Test the view used is the default view if GPUTexture is used instead of GPUTextureView gpuweb/cts#4426

Open

4 tasks

Chainsawkitten added a commit to Chainsawkitten/WebGPUReconstruct that referenced this pull request Aug 5, 2025

Texture as TextureView

25605fb

gpuweb/gpuweb#5228 allows using GPUTexture instead of GPUTextureView in a number of places.

juj added a commit to juj/wasm_webgpu that referenced this pull request Sep 12, 2025

IDL: Allow GPUTexture where GPUTextureView is used. gpuweb/gpuweb#5228

02cdc42

No functional changes since the object types are not strongly checked in the Wasm -> JS bridge.

Allow GPUTexture where GPUTextureView is used #5228

Allow GPUTexture where GPUTextureView is used #5228

Uh oh!

Conversation

beaufortfrancois commented Jun 20, 2025

Uh oh!

github-actions bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

toji left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

beaufortfrancois left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

toji left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

beaufortfrancois commented Jul 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

toji left a comment

Choose a reason for hiding this comment

Uh oh!

dneto0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

beaufortfrancois commented Jul 4, 2025

Uh oh!

kainino0x commented Jul 7, 2025

Uh oh!

toji commented Jul 7, 2025

Uh oh!

beaufortfrancois commented Jul 7, 2025

Uh oh!

This comment was marked as spam.

Uh oh!

github-actions bot commented Jun 20, 2025 •

edited

Loading