Skip to content

Conversation

@FlorianLoch
Copy link
Contributor

@FlorianLoch FlorianLoch commented Feb 1, 2021

See #150 .

Summary of Changes

  1. extend tests to verify the problem
  2. extend signature of helpers.requestToken() to also return error to differentiate between an empty/non-existing
    token and an actual error
  3. check for empty token and raise ErrNoToken
  4. remove conditional never becoming true
  5. added myself to the AUTHORS file. I am not craving for fame and I am not vain either, I just assumed it to be good style with this repo. Please drop this if I am wrong.

@FlorianLoch
Copy link
Contributor Author

Any feedback on this?

Copy link
Contributor

@elithrar elithrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style nit.

@FlorianLoch FlorianLoch requested a review from elithrar April 11, 2021 18:01
@FlorianLoch
Copy link
Contributor Author

Are we good to go? ;)

Copy link
Contributor

@elithrar elithrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @FlorianLoch - !

@elithrar elithrar merged commit b69cbb3 into gorilla:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants