[build] Add CircleCI config #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
No images available for older versions of Go (<= 1.6). Need to determine if we leave older versions untested/unsupported. |
Contributor
|
It's been 3.5 years since Go 1.6, probably safe to drop that. Also considering the point of this package is security, anyone on that version is starting off way behind as it is :) |
Contributor
Author
|
Ha, very true. I always like to leave these things open a few days, but I
think we can move on!
…On Tue, Jun 25, 2019 at 2:26 PM Kamil Kisiel ***@***.***> wrote:
It's been 3.5 years since Go 1.6, probably safe to drop that. Also
considering the point of this package is security, anyone on that version
is starting off way behind as it is :)
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#112?email_source=notifications&email_token=AAAEQ4H2JFNF36ZWG5ACQ5LP4KEOLA5CNFSM4H3MK5X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYRUR5Y#issuecomment-505628919>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAEQ4AG7IPU2JZL5E3TTM3P4KEOLANCNFSM4H3MK5XQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.