-
-
Notifications
You must be signed in to change notification settings - Fork 902
Closed
Labels
Description
Bug
After bumping to 4.6.3 to, when the BottomSheetScrollView
component is rendered in jest environment it now prints the following console.warn():
Couldn't find the scrollable node handle id!
Other than that, everything is fully functional in runtime and test environment.
It's mostly a result of this change: #1823 (but console.warn is still much better than the Unexpected nativeTag: object; nativeTag=undefined
error that was thrown before 🙏 🙏 )
Environment info
Library | Version |
---|---|
@gorhom/bottom-sheet | 4.6.3 |
react-native | 0.74.5 |
react-native-reanimated | 3.10.1 |
react-native-gesture-handler | 2.16.2 |
Steps To Reproduce
- Execute a jest tests that is rendering any component tree including
BottomSheetScrollView
- "Couldn't find the scrollable node handle id!" warning is printed
Describe what you expected to happen:
I expected no console.warn
s to be printed.
Printing useless console warnings is a bad pattern and especially annoying in setups like ours when using jest-fail-on-console
to disallow any console logs in tests execution.