Skip to content

Conversation

bramp
Copy link
Contributor

@bramp bramp commented Nov 27, 2017

The original config.toml doesn't generate a valid site, but is the one used by default. Fixes #236

… doesn't generate a valid site, but is the one used by default. Fixes #236
@bketelsen
Copy link
Contributor

are you sure this needs to be done?
see #236 (comment) for hugo's production configuration.

@bramp
Copy link
Contributor Author

bramp commented Nov 27, 2017

ah sorry yes, race condition between mine and your comments (I didn't see yours before this PR).

Well I don't see how the prod config choses the config-main.toml over the default. But for completeness I'll get a old hugo and see what it does.

But at least something has to be done. Either update the README to say use Hugo 0.15, or tell users to use --config config-main.toml, or this PR.

@bep
Copy link
Contributor

bep commented Nov 27, 2017

I haven't tested this, but I would guess that it is the layouts-main config value that is missing in one of those files.

I see no good reason to not use the Hugo default (i.e. layouts) for this folder. I would suggest just removing those "special" config options and rename the layouts folder. As it is now, people looking at it will think it is "something special that I don't understand".

@bramp
Copy link
Contributor Author

bramp commented Nov 28, 2017

Ah I'm going to abandon this... So the reason this works in prod, is because the theme is specified on the command line. If I do the same it works, so it does appear hugo is set up to have two different configurations, a config.toml (using gaweb) and config-main.toml using the theme defined in the layouts-main directory.

Coming back I see that #239 is a simple fix to specify the theme in the config, and testing their change it seems to fix my issues.

@bramp bramp closed this Nov 28, 2017
config.toml Outdated
layoutdir = "layouts-main"
publishdir = "public-main"
layoutdir = "layouts"
publishdir = "public"
Copy link
Contributor

@bep bep Nov 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing those settings entirely. Those are the defaults, and these will never change in Hugo. This also includes the contentDir above.

@bketelsen
Copy link
Contributor

even better just delete the config-main file It's not used anymore and causes way too much confusion. There used to be two sites served from this same repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants