Please help to review this post for Dec 27th #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrislusf
changed the title
|
|
||
| +++ | ||
|
|
||
| Having been a Java developer for many years, I simply lose interest |
There was a problem hiding this comment.
I would change:
"I simply lose"
to
"I have simply lost"
|
Hi @chrislusf, Interesting post, I'll have to study the code more asap. I went through and commented on what I thought were obvious issues in the text, but note that I'm not a native English speaker, so hopefully a native English speaker can confirm/reject my change proposals! Best |
|
Thanks a lot for the suggestions! |
mattfarina
added a commit
that referenced
this pull request
Dec 27, 2015
Please help to review this post for Dec 27th
|
Thanks for the post. It's now up at https://blog.gopheracademy.com/advent-2015/glow-map-reduce-for-golang/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need a second pair of eyes to read this. Also, since it's a fairly big topic, please suggest where it needs clarification.