Skip to content
This repository was archived by the owner on Oct 29, 2023. It is now read-only.

Conversation

@deflaux
Copy link
Contributor

@deflaux deflaux commented Apr 7, 2015

Also add validation to --output which fixes #31

Also add validation to --output which fixes googlegenomics#31
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.11%) to 26.11% when pulling a33e2ed on deflaux:master into 07cf23f on googlegenomics:master.

@deflaux
Copy link
Contributor Author

deflaux commented Apr 7, 2015

@wbrockman please take a look

These changes go with the new task-oriented docs for our dataflow jobs (currently in review) http://googlegenomics.readthedocs.org/en/staging/use_cases/compute_identity_by_state/index.html

@deflaux
Copy link
Contributor Author

deflaux commented Apr 8, 2015

I was just reading https://cloud.google.com/compute/docs/gcloud-compute/ which supports gcloud auth login --no-launch-browser

Perhaps --no-launch-browser might be a better option name here than --headless?

@dionloy
Copy link
Contributor

dionloy commented Apr 8, 2015

SGTM, even if it is poor english =).

On Wed, Apr 8, 2015 at 10:36 AM Nicole Deflaux [email protected]
wrote:

I was just reading https://cloud.google.com/compute/docs/gcloud-compute/
which supports gcloud auth login --no-launch-browser

Perhaps --no-launch-browser might be a better option name here than
--headless?


Reply to this email directly or view it on GitHub
#50 (comment)
.

Modeled after gcloud auth login --no-launch-browser
@deflaux
Copy link
Contributor Author

deflaux commented Apr 9, 2015

@dionloy please take a look

These changes go with the new task-oriented docs for our dataflow jobs (currently in review) http://googlegenomics.readthedocs.org/en/staging/use_cases/compute_identity_by_state/index.html which I just updated to --noLaunchBrowser

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.11%) to 26.11% when pulling bf9e38d on deflaux:master into 07cf23f on googlegenomics:master.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:: intentional ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, its in reStructured text format

you can see that the format is wrong at the moment here https://github.com/googlegenomics/dataflow-java/blob/master/README.rst#updating-the-prebuilt-jar and this fixes it

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.11%) to 26.11% when pulling 5a5c932 on deflaux:master into 07cf23f on googlegenomics:master.

@dionloy
Copy link
Contributor

dionloy commented Apr 9, 2015

LGTM

On Thu, Apr 9, 2015 at 11:37 AM Coveralls [email protected] wrote:

[image: Coverage Status] https://coveralls.io/builds/2302900

Coverage decreased (-0.11%) to 26.11% when pulling 5a5c932
5a5c932
on deflaux:master
into 07cf23f
07cf23f
on googlegenomics:master
.


Reply to this email directly or view it on GitHub
#50 (comment)
.

deflaux added a commit that referenced this pull request Apr 9, 2015
Add support for headless usage.
@deflaux deflaux merged commit 9dc348b into googlegenomics:master Apr 9, 2015
jiridanek pushed a commit to jiridanek/dataflow-java that referenced this pull request Jan 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VariantSimilarity: Dataflow job creation fails with a 400

3 participants