This repository was archived by the owner on Oct 29, 2023. It is now read-only.
Refactor auth. #159
Merged
Refactor auth. #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also default to use gRPC for VariantSimilarity.
Contributor
There was a problem hiding this comment.
remove space between Scanner and (
Contributor
|
LGTM, just that nit. |
Contributor
Author
|
All integration tests have passed (Travis does not run those). |
jiridanek
pushed a commit
to jiridanek/dataflow-java
that referenced
this pull request
Jan 18, 2016
Refactor auth.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the first commit in this PR was already reviewed as #158 but I could not merge that PR due to the other changes in util-java, which are taken care of by the second commit here.