Skip to content
This repository was archived by the owner on Oct 29, 2023. It is now read-only.

Conversation

@deflaux
Copy link
Contributor

@deflaux deflaux commented Dec 2, 2015

It still needs more testing to verify correctness of results, but it runs to completion successfully.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space between "This" and "("

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. It also needed a correction since the variantSet from which we get the allelic frequencies will generally not be in the same dataset as the reads.

@dionloy dionloy assigned deflaux and unassigned dionloy Dec 2, 2015
@deflaux deflaux assigned dionloy and unassigned deflaux Dec 3, 2015
@dionloy
Copy link
Contributor

dionloy commented Dec 3, 2015

LGTM

Thanks!

deflaux added a commit that referenced this pull request Dec 3, 2015
Merge VerifyBamId to master.
@deflaux deflaux merged commit 78218e1 into googlegenomics:master Dec 3, 2015
@Careyjmac
Copy link
Contributor

Randomly decided to check up on this, and noticed it finally got merged in! Yay! Hope everyone is doing well :)

@deflaux
Copy link
Contributor Author

deflaux commented Dec 9, 2015

Yeah @Careyjmac !!! Thanks again for this very cool pipeline and hope things are going great for you too!

jiridanek pushed a commit to jiridanek/dataflow-java that referenced this pull request Jan 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants