chore: re-work integration test infrastructure #906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #906 +/- ##
=======================================
Coverage 87.84% 87.84%
=======================================
Files 153 153
Lines 16046 16046
Branches 1166 1166
=======================================
Hits 14095 14095
Misses 1607 1607
Partials 344 344 Continue to review full report at Codecov.
|
vam-google
suggested changes
Jan 21, 2022
Contributor
vam-google
left a comment
vam-google
left a comment
There was a problem hiding this comment.
Please hold off the test infrastructure re-work work. See the comment in #904 (comment) outlining some of the problems. Le'ts look into this closer during our weekly sync, or we can have a separate sync about this kind of stuff.
Contributor
Author
|
Had offline discusisons. @vam-google are you comfortable lifting the merge block? |
meltsufin
approved these changes
Jan 26, 2022
vam-google
approved these changes
Jan 26, 2022
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
* chore: make integration test infra sane * chore: de-bazelize updating golden files * chore: simplify * chore: remove integration_test.bzl
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing in the same spirit to #904.
This completely removes
integration_test.bzl.