-
Notifications
You must be signed in to change notification settings - Fork 70
[samplecode][2/3]Implement Stream.Bidi sample code #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
78e9281
[samplecode][1/3]Implement Pure Unary RPC sample code (#573)
summer-ji-eng f9700b8
[samplecode][1/3]Implement Pure Unary RPC sample code (#573)
summer-ji-eng 04c6c25
rebase #616
summer-ji-eng 15a0f7a
rebase samplecode with dev_composer
summer-ji-eng 971cd4c
implement stream server sample code
summer-ji-eng 06cd2e7
add comments
summer-ji-eng 3f6e818
add error message
summer-ji-eng 19986fd
Implement Strem.Bidi sample code
summer-ji-eng a14cc0a
address the comments
summer-ji-eng 8b719b7
fix error message
summer-ji-eng 10184b7
revert repeated error msg
summer-ji-eng 6b0a999
Addressed the error msg
summer-ji-eng b6cd7a0
Implement Strem.Bidi sample code
summer-ji-eng c00f9b1
address the comments
summer-ji-eng 90bfce8
Merge branch 'samplecode-master' into stream_bidi_sample_code
summer-ji-eng d0d3901
fix format
summer-ji-eng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this method is already named
bidi, do the variable names still needbidiin them?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used
bidiStreamto match the original sample code syntax, but I am open to the variable name. A stream variable in server isstream, so I think it make sense usestreaminstead ofbidiStream. Are you also preferring usingstreaminstead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's for matching the variable name, then
bidiStreamLGTM.