Skip to content

[ggj][parsing] fix: gate isPaged on all fields for monolith back-compat #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miraleung merged 11 commits into from
Nov 21, 2020
Merged

[ggj][parsing] fix: gate isPaged on all fields for monolith back-compat #538

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bb8f2f2
fix: align resname ctors with superclass variants
miraleung Nov 19, 2020
59d8338
Merge branch 'master' of github.com:googleapis/gapic-generator-java i…
miraleung Nov 19, 2020
7336db7
fix: avoid type collisions - refactor {Concrete,Vapor}Ref into AstNodes
miraleung Nov 20, 2020
2f7c857
fix: better message null checks in Parser
miraleung Nov 20, 2020
8814542
fix: map proto.Empty RPC types to void in ServiceClient
miraleung Nov 20, 2020
ca8398f
fix: improve import(shortName) state-keeping in ImportWriterVisitor
miraleung Nov 20, 2020
b48f494
fix: fix stub pkg for all ServiceSettingsStub usages
miraleung Nov 20, 2020
93ed4bd
fix: handle older protos with javaMultipleFiles=false
miraleung Nov 20, 2020
bb7d59f
fix: gate isPaged on all fields for monolith back-compat
miraleung Nov 20, 2020
af575a6
Merge branch 'master' into ag/7
miraleung Nov 21, 2020
66a8c0f
Merge branch 'master' into ag/7
miraleung Nov 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/main/java/com/google/api/generator/gapic/protoparser/Parser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,10 +437,14 @@ static LongrunningOperation parseLro(
static boolean parseIsPaged(
MethodDescriptor methodDescriptor, Map<String, Message> messageTypes) {
Message inputMessage = messageTypes.get(methodDescriptor.getInputType().getName());
Message outputMessage = messageTypes.get(methodDescriptor.getInputType().getName());
Message outputMessage = messageTypes.get(methodDescriptor.getOutputType().getName());

// This should technically handle the absence of either of these fields (aip.dev/158), but we
// gate on their collective presence to ensure the generated surface is backawrds-compatible
// with monolith-gnerated libraries.
return inputMessage.fieldMap().containsKey("page_size")
|| inputMessage.fieldMap().containsKey("page_token")
|| outputMessage.fieldMap().containsKey("next_page_token");
&& inputMessage.fieldMap().containsKey("page_token")
&& outputMessage.fieldMap().containsKey("next_page_token");
}

@VisibleForTesting
Expand Down