Skip to content

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Jan 7, 2025

follow-up to #3513,

Changes in this PR:

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 7, 2025
@zhumin8 zhumin8 requested review from blakeli0 and lqiu96 January 7, 2025 15:50
@zhumin8 zhumin8 changed the title test: Update the golden files' copyright to 2025 test: Update the gapic-generator golden files' copyright to 2025 Jan 7, 2025
Copy link
Contributor

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Min! Can you please make it clear that these golden files do not fail the unit tests? And they might get cleaned up in the future.

@zhumin8 zhumin8 changed the title test: Update the gapic-generator golden files' copyright to 2025 test: Update the gapic-generator and hermetic-build golden files' copyright to 2025 Jan 7, 2025
@zhumin8
Copy link
Contributor Author

zhumin8 commented Jan 7, 2025

Updated description to provide more info.

@zhumin8
Copy link
Contributor Author

zhumin8 commented Jan 7, 2025

Hermetic library generation upon generation config change through pull requests / library_generation (pull_request) Failing after 31m

  File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/release_note_generation/generate_pr_description.py", line 114, in get_repo_level_commit_messages
    raise ValueError(
ValueError: current_commit (f17e0aa, committed on 1734006769) should be newer than or equal to baseline_commit (3cef095, committed on 1736181309) (is this branch up to date with the base branch?).
Error: Process completed with exit code 1.

Based on description in script here:

# This script is used to, when a pull request changes the generation
# configuration (generation_config.yaml by default) or Dockerfile:

I am not sure if this test should run on this pr?

UPDATE: hint from above error, merge main into this resolved it.

Copy link

sonarqubecloud bot commented Jan 7, 2025

Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zhumin8 zhumin8 merged commit 816f155 into main Jan 7, 2025
50 of 51 checks passed
@zhumin8 zhumin8 deleted the fix-license-header-year branch January 7, 2025 23:50
lqiu96 pushed a commit that referenced this pull request Feb 20, 2025
…yright to 2025 (#3550)

follow-up to #3513, 

Changes in this PR:
- generated by ` mvn test -DupdateUnitGoldens ` from
gapic-generator-java/. Note that unit tests without this change did not
fail. Filed #3556
to investigate and maybe remove these in the future.
- library-generation unit test golden files. They are causing test
failures in
https://github.com/googleapis/sdk-platform-java/actions/runs/12659566586/job/35278951040?pr=3462
These 2 files are used in unit tests to test logic in owlbot to insert
header when they are missing. e.g.
https://github.com/googleapis/sdk-platform-java/blob/67f5ea23f50eaf57925cdf34d51c7b0bfcc67cf3/hermetic_build/library_generation/owlbot/synthtool/languages/java.py#L113-L116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants