Skip to content

[ggj][ast] feat: add comment statement check in class definition #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaozhenliu-gg5 merged 1 commit into from
Aug 31, 2020
Merged

[ggj][ast] feat: add comment statement check in class definition #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/com/google/api/generator/engine/ast/ClassDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,10 @@ public ClassDefinition build() {
}

for (Statement statement : classDef.statements()) {
// TODO(xiaozhenliu): Add CommentStatement check here.
Preconditions.checkState(
statement instanceof ExprStatement || statement instanceof BlockStatement,
statement instanceof ExprStatement
|| statement instanceof BlockStatement
|| statement instanceof CommentStatement,
"Class statement type must be either an expression, block, or comment statement");
if (statement instanceof ExprStatement) {
Expr expr = ((ExprStatement) statement).expression();
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/com/google/api/generator/engine/ast/ClassDefinitionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,15 @@ public void validClassDefinition_basicWithCommentsAndHeader() {
}

@Test
public void validClassDefinition_exprAndBlockStatements() {
public void validClassDefinition_exprCommentAndBlockStatements() {
ClassDefinition.builder()
.setName("LibraryServiceStub")
.setIsNested(true)
.setScope(ScopeNode.PUBLIC)
.setStatements(
Arrays.asList(
BlockStatement.builder().setIsStatic(true).build(),
CommentStatement.withComment(LineComment.withComment("Test line comment.")),
ExprStatement.withExpr(
AssignmentExpr.builder()
.setVariableExpr(
Expand Down