Skip to content

Conversation

@renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Dec 18, 2025

This PR contains the following updates:

Package Change Age Confidence
minitest (source, changelog) "~> 5.25.0" -> "~> 6.0.0" age confidence

Release Notes

minitest/minitest (minitest)

v6.0.1

Compare Source

v6.0.0

Compare Source

v5.27.0

Compare Source

v5.26.2

Compare Source

v5.26.1

Compare Source

v5.26.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested review from a team and olavloite as code owners December 18, 2025 00:00
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 18, 2025
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/ruby-spanner-activerecord API. label Dec 18, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a routine but significant dependency update, specifically upgrading the minitest testing framework to its major version 6.0.0. This update aims to ensure the project benefits from the latest features, improvements, and security patches offered by the new minitest release, maintaining the robustness and modernity of the testing suite.

Highlights

  • Dependency Update: The minitest gem has been updated from version ~> 5.25.0 to ~> 6.0.0. This is a major version bump, indicating potential breaking changes that should be reviewed.
  • Automated Update: This pull request was automatically generated by Renovate bot to keep project dependencies up-to-date.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minitest dependency to version 6. While keeping dependencies up-to-date is good practice, this major version upgrade introduces breaking changes that are not addressed in this PR. Specifically, Minitest v6 requires minitest/spec to be explicitly required for tests using the describe syntax. Without this change, the test suite will fail. I've added a critical comment on the Gemfile change with details on how to resolve this.

gem "activerecord", ar_version
gem "ostruct"
gem "minitest", "~> 5.25.0"
gem "minitest", "~> 6.0.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Updating minitest to version 6.0 introduces breaking changes that will likely cause your test suite to fail.

Minitest v6 no longer loads Minitest::Spec by default. Your tests in test/activerecord_spanner_adapter/connection_mock_server_test.rb use the describe syntax, which is part of Minitest::Spec.

To fix this, you'll need to explicitly require minitest/spec in your test helper file (test/test_helper.rb).

# In test/test_helper.rb
require "minitest/spec"

Without this change, you'll likely see NoMethodError: undefined method 'describe' for SpannerMockServerConnectionTest:Class errors when running your tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/ruby-spanner-activerecord API. kokoro:force-run Add this label to force Kokoro to re-run the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant