-
Notifications
You must be signed in to change notification settings - Fork 35
chore(deps): update dependency minitest to v6 #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine but significant dependency update, specifically upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the minitest dependency to version 6. While keeping dependencies up-to-date is good practice, this major version upgrade introduces breaking changes that are not addressed in this PR. Specifically, Minitest v6 requires minitest/spec to be explicitly required for tests using the describe syntax. Without this change, the test suite will fail. I've added a critical comment on the Gemfile change with details on how to resolve this.
| gem "activerecord", ar_version | ||
| gem "ostruct" | ||
| gem "minitest", "~> 5.25.0" | ||
| gem "minitest", "~> 6.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating minitest to version 6.0 introduces breaking changes that will likely cause your test suite to fail.
Minitest v6 no longer loads Minitest::Spec by default. Your tests in test/activerecord_spanner_adapter/connection_mock_server_test.rb use the describe syntax, which is part of Minitest::Spec.
To fix this, you'll need to explicitly require minitest/spec in your test helper file (test/test_helper.rb).
# In test/test_helper.rb
require "minitest/spec"Without this change, you'll likely see NoMethodError: undefined method 'describe' for SpannerMockServerConnectionTest:Class errors when running your tests.
This PR contains the following updates:
"~> 5.25.0"->"~> 6.0.0"Release Notes
minitest/minitest (minitest)
v6.0.1Compare Source
v6.0.0Compare Source
v5.27.0Compare Source
v5.26.2Compare Source
v5.26.1Compare Source
v5.26.0Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.