Skip to content

test: reduce system test flakiness #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2021
Merged

test: reduce system test flakiness #642

merged 1 commit into from
Oct 29, 2021

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Oct 28, 2021 •
edited
Loading

Reduce flakiness in system test test_bucket_w_default_kms_key_name

Fixes #643 🦕

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Oct 28, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 28, 2021
@cojenco cojenco marked this pull request as ready for review October 28, 2021 20:52
@cojenco cojenco requested review from a team as code owners October 28, 2021 20:52
unforced
unforced approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@unforced unforced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/system/test_kms_integration.py
blobs_to_delete.append(defaulted_blob)

assert defaulted_blob.download_as_bytes() == payload
_helpers.retry_429_harder(_helpers.retry_has_kms_key_name(defaulted_blob.reload))()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giggling at the function name 😆

@cojenco cojenco merged commit 0b7838a into googleapis:main Oct 29, 2021
@cojenco cojenco deleted the flaky-sys branch December 3, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@unforced unforced unforced approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky systest test_bucket_w_default_kms_key_name
2 participants
@cojenco @unforced