fix(tests): remove low version error assertion from iam conditions system tests #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jkwlui
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tseaver
reviewed
Feb 12, 2020
| with pytest.raises( | ||
| BadRequest, match="cannot be less than the existing policy version" | ||
| ): | ||
| bucket.get_iam_policy() |
There was a problem hiding this comment.
Do we have a definite confirmation that the backend no longer raises this exception under any circumstance?
There was a problem hiding this comment.
We have an internal group with a conversation. Yes.
crwilcox
approved these changes
Feb 12, 2020
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52