Skip to content

fix(storage): fix system test and change scope for iam access token #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 12, 2020
Merged

fix(storage): fix system test and change scope for iam access token #47

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
20a315d
fix(storage): change scope for iam access token
HemangChothani Feb 5, 2020
cc7aa31
Merge branch 'master' into storage_fix_system_test
crwilcox Feb 11, 2020
2a52b97
fix: narrow scope
crwilcox Feb 11, 2020
10adc53
fix: trailing commas
crwilcox Feb 11, 2020
90854a9
chore: blacken
crwilcox Feb 11, 2020
ea9dca6
Merge branch 'master' into storage_fix_system_test
crwilcox Feb 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions tests/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,8 +968,8 @@ def _create_signed_read_url_helper(
method=method,
client=Config.CLIENT,
version=version,
service_account_email=None,
access_token=None,
service_account_email=service_account_email,
access_token=access_token,
)

headers = {}
Expand Down Expand Up @@ -1046,7 +1046,10 @@ def test_create_signed_read_url_v2_w_access_token(self):
client = iam_credentials_v1.IAMCredentialsClient()
service_account_email = Config.CLIENT._credentials.service_account_email
name = client.service_account_path("-", service_account_email)
scope = ["https://www.googleapis.com/auth/devstorage.read_write"]
scope = [
"https://www.googleapis.com/auth/devstorage.read_write",
"https://www.googleapis.com/auth/iam",
]
response = client.generate_access_token(name, scope)
self._create_signed_read_url_helper(
service_account_email=service_account_email,
Expand All @@ -1057,7 +1060,10 @@ def test_create_signed_read_url_v4_w_access_token(self):
client = iam_credentials_v1.IAMCredentialsClient()
service_account_email = Config.CLIENT._credentials.service_account_email
name = client.service_account_path("-", service_account_email)
scope = ["https://www.googleapis.com/auth/devstorage.read_write"]
scope = [
"https://www.googleapis.com/auth/devstorage.read_write",
"https://www.googleapis.com/auth/iam",
]
response = client.generate_access_token(name, scope)
self._create_signed_read_url_helper(
version="v4",
Expand Down