Skip to content

fix(storage): fix documentation of max_result parameter in list_blob #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2020
Merged

fix(storage): fix documentation of max_result parameter in list_blob #43

merged 1 commit into from
Feb 11, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #19

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 4, 2020
@HemangChothani HemangChothani mentioned this pull request Feb 10, 2020
Closed
This was referenced Feb 10, 2020
Closed
Closed
Closed
frankyn
frankyn approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the Pages iterator that exists right now this change makes sense.

I added a workaround in the associated issue for now in case users want to request X items per page and all items. I do consider this a usability issue.

@frankyn frankyn merged commit ff15f19 into googleapis:master Feb 11, 2020
@yoshi-automation yoshi-automation mentioned this pull request Feb 19, 2020
Merged
@olfek olfek mentioned this pull request Apr 30, 2021
Closed
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @cojenco
fix(storage): fix documentation of max_result parameter in list_blob (g…
e72d5b3 
…oogleapis#43)
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @cojenco
fix(storage): fix documentation of max_result parameter in list_blob (g…
da9cf73 
…oogleapis#43)
@release-please release-please bot mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver Awaiting requested review from tseaver

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage: Bucket.list_blobs(max_results=n) does not behave as documented
3 participants
@HemangChothani @frankyn @googlebot