Skip to content

chore: prevent normalization of semver versioning #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2021
Merged

chore: prevent normalization of semver versioning #410

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c9d3c9
chore: prevent normalization of semver versioning
dandhlee Apr 14, 2021
2fcc916
chore: use workaround to make sic work
dandhlee Apr 15, 2021
ca1707b
chore: update for Python2 to make sic work
dandhlee Apr 15, 2021
737d983
Merge branch 'master' into remove-semver-normalization
dandhlee Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,20 @@

import setuptools

# Disable version normalization performed by setuptools.setup()
try:
# Try the approach of using sic(), added in setuptools 46.1.0
from setuptools import sic
except ImportError:
# Try the approach of replacing packaging.version.Version
sic = lambda v: v
try:
# setuptools >=39.0.0 uses packaging from setuptools.extern
from setuptools.extern import packaging
except ImportError:
# setuptools <39.0.0 uses packaging from pkg_resources.extern
from pkg_resources.extern import packaging
packaging.version.Version = packaging.version.LegacyVersion

# Package metadata.

Expand Down Expand Up @@ -63,7 +77,7 @@

setuptools.setup(
name=name,
version=version,
version=sic(version),
description=description,
long_description=readme,
author="Google LLC",
Expand Down