Skip to content

Conversation

@googlyrahman
Copy link

These changes are prototype for async downloads to compare the performance of gcsfs async with SDK async. These changes should not be merged.

@googlyrahman googlyrahman requested review from a team as code owners November 12, 2025 20:29
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Nov 12, 2025
@googlyrahman googlyrahman marked this pull request as draft November 12, 2025 20:29
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Nov 12, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @googlyrahman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request serves as an experimental prototype to evaluate the performance of asynchronous downloads within the Google Cloud Storage SDK, specifically comparing it against gcsfs async. It establishes foundational async client components and a flexible download mechanism that supports both traditional sequential and advanced sliced (parallel) downloading for large files. The author has indicated that these changes are for testing purposes and are not intended for merging.

Highlights

  • Async Client Infrastructure: Introduces Client and ClientWithProjectAsync classes in _helpers.py to manage asynchronous credentials and HTTP sessions using aiohttp_requests.
  • Asynchronous Download Client: Adds AsyncClient in async_client.py with a download_to_file method, enabling both sequential and experimental sliced (parallel) downloads for large objects.
  • Sliced Download Logic: Implements a _check_if_sliced_download_is_eligible method to determine if a file (over 1GB and without checksum validation) can be downloaded in parallel chunks.
  • Async Download Mechanism: Defines DownloadAsync in download.py to handle the actual asynchronous streaming of data, including partial content handling and optional checksum validation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an experimental implementation for asynchronous downloads, including a parallel sliced download strategy. The code is a good starting point for a prototype. My review focuses on several areas for improvement, particularly around the use of synchronous I/O within async functions, which can block the event loop and negate the benefits of asyncio. I've also pointed out opportunities to improve code clarity by removing dead code and replacing magic numbers with constants. There are also some potential bugs related to status code handling and hardcoded values that should be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants