Skip to content

fix: filter download_kwargs in BlobReader #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2025
Merged

fix: filter download_kwargs in BlobReader #1411

merged 2 commits into from
Jan 22, 2025

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Jan 9, 2025

Fixes #1406 🦕

@cojenco cojenco requested review from a team as code owners January 9, 2025 19:43
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 9, 2025
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jan 9, 2025
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2025
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 13, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 13, 2025
andrewsg
andrewsg approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 16, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 16, 2025
@cojenco cojenco merged commit 0c21210 into googleapis:main Jan 22, 2025
13 checks passed
@release-please release-please bot mentioned this pull request Jan 22, 2025
Merged
cojenco added a commit that referenced this pull request Feb 4, 2025
@cojenco
fix: filter download_kwargs in BlobReader (#1411)
0780ea5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

Assignees

@andrewsg andrewsg

Labels
api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to call seek when a BlobReader instance initialized with raw_download parameter
3 participants
@cojenco @andrewsg @yoshi-kokoro