test: dedup kms_bucket fixture #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
product-auto-label
bot
added
size: m
cojenco
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
cojenco
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
cojenco
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
cojenco
changed the title
cojenco
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
andrewsg
reviewed
Sep 27, 2023
andrewsg
approved these changes
Oct 11, 2023
andrewsg
added
the
automerge
cojenco
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding back KMS permissions to the kokoro project, KMS integration tests now pass.
However, upon investigation, I noticed that we have a duplicate set of kms pytest fixtures. This removes the duplicates and changes fixture scope to per-function.
Fixes #1128