tests: re-enable cross-language conformance tests #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: firestore
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tseaver
commented
Sep 25, 2020
tseaver
commented
Sep 25, 2020
tseaver
commented
Sep 25, 2020
Add a rule to the makefile to make it easier in the future to update them
Partially reverts 84868a1 Rationale: get the conftest runner working using existing semantics, before updating the JSON files and making required changes (to use 'update_transforms', for instance) in a future PR.
tseaver
force-pushed
the
95-tests-reenable_conformance_tests
branch
from
4c13243 to
0e4270b
Compare
Contributor
Author
|
@crwilcox PTAL. |
crwilcox
approved these changes
Oct 7, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: still need to actually fix the tests, but they are at least running.Closes: #95