Skip to content

[CHANGE ME] Re-generated to pick up changes from self. #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yoshi-automation wants to merge 1 commit into from
Closed

[CHANGE ME] Re-generated to pick up changes from self. #197

yoshi-automation wants to merge 1 commit into from

Conversation

@yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Sep 23, 2020

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/5b70dc45-64d2-4249-ae65-df9fc92489a3/targets

  • To automatically regenerate this PR, check this box.

@yoshi-automation
changes without context
2adb47a 
        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2020
tseaver
tseaver reviewed Sep 23, 2020
View reviewed changes
google/cloud/firestore_admin_v1/services/firestore_admin/async_client.py
exceptions.DeadlineExceeded,
exceptions.InternalServerError,
exceptions.ServiceUnavailable,
exceptions.DeadlineExceeded,
Copy link
Contributor

@tseaver tseaver Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@busunkim96, @crwilcox, @software-dov Here we are again re-ordering exception types. Note that some changes below are not alpha-sorted.

Copy link
Contributor

@busunkim96 busunkim96 Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened googleapis/gapic-generator-python#617 to track.

tseaver added a commit that referenced this pull request Sep 23, 2020
@tseaver
chore: update to gapic-generator-python 0.33.5
d363117 
Closes: #197
Closes: #198
Closes: #199
@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 23, 2020
@tseaver tseaver mentioned this pull request Sep 23, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 23, 2020
@tseaver
chore: fix 'pytype' via manual synth (#201)
2021f38 
Supersedes: #197, #198, #199
@tseaver tseaver closed this Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tseaver tseaver tseaver left review comments

@busunkim96 busunkim96 busunkim96 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. context: none do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshi-automation @tseaver @busunkim96