Skip to content

fix: avoid rounding problems with microseconds #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 4, 2021
Merged

fix: avoid rounding problems with microseconds #20

merged 5 commits into from
Oct 4, 2021

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Sep 30, 2021 •
edited
Loading

TODO:

  • More tests with fractional precision
  • Actually fix the failing tests

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #18 🦕

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Sep 30, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2021
@tswast tswast mentioned this pull request Sep 30, 2021
Closed
@tswast tswast marked this pull request as ready for review October 4, 2021 17:35
@tswast tswast requested a review from a team as a code owner October 4, 2021 17:35
@tswast tswast requested review from a team and shollyman and removed request for a team October 4, 2021 17:36
@tswast tswast requested a review from a team October 4, 2021 17:42
@tswast tswast merged commit 0ff7371 into main Oct 4, 2021
@tswast tswast deleted the issue18-divmod branch October 4, 2021 20:58
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 4, 2021
@release-please
chore: release 0.1.1 (#24)
f162631 
🤖 I have created a release \*beep\* \*boop\*
---
### [0.1.1](https://www.github.com/googleapis/python-db-dtypes-pandas/compare/v0.1.0...v0.1.1) (2021-10-04)


### Bug Fixes

* avoid rounding problems with microseconds ([#20](https://www.github.com/googleapis/python-db-dtypes-pandas/issues/20)) ([0ff7371](https://www.github.com/googleapis/python-db-dtypes-pandas/commit/0ff737120344602f49889596b1efa69a6a18a057))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman Awaiting requested review from shollyman

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

potential rounding error with use of divmod

3 participants

@tswast @tseaver