Skip to content

ci: run 'mypy' against 'google/', 'tests/' #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 7 commits into from
Nov 13, 2021
Merged

ci: run 'mypy' against 'google/', 'tests/' #251

gcf-merge-on-green merged 7 commits into from
Nov 13, 2021

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 9, 2021

Closes #240.

@tseaver tseaver requested review from crwilcox and kolea2 November 9, 2021 16:31
@tseaver tseaver requested a review from a team as a code owner November 9, 2021 16:31
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Nov 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2021
chrisrossi
chrisrossi approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Nov 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 92848d3 into main Nov 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the 240-ci-moar-mypy branch November 13, 2021 12:46
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

@kolea2 kolea2 Awaiting requested review from kolea2

1 more reviewer

@chrisrossi chrisrossi chrisrossi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datastore Issues related to the googleapis/python-datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a py.typed file for submodule

3 participants

@tseaver @chrisrossi @parthea