chore(tests): sync client verification tests #1046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 245bd08.
product-auto-label
bot
added
size: l
daniel-sanche
force-pushed
the
cross_sync2_pr4_tests
branch
from
30bef41 to
dfb3dc1
Compare
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
daniel-sanche
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
mutianf
approved these changes
Dec 17, 2024
| - client-type: "sync" | ||
| # sync client does not support concurrent streams | ||
| test_args: "-skip _Generic_MultiStream" | ||
| - client-type: "legacy" |
Contributor
There was a problem hiding this comment.
Im wondering if we could remove this
Contributor
Author
There was a problem hiding this comment.
Yeah for sure, I opened #1054 to track this
Co-authored-by: Mattie Fu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #1017
This PR adds two new tests to verify the new sync outputs: