chore: remove local test_utils directory #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
HemangChothani
approved these changes
Apr 29, 2020
Contributor
HemangChothani
left a comment
HemangChothani
left a comment
There was a problem hiding this comment.
LGTM!
System tests failed which is not relevant to changes.
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
Author
|
I noticed that system test failure on another branch, too, but thought it has something to do with changes I was making to how BQ Storage client is used. I now see that it can also happen on I cannot reproduce it locally, however, I only observed it on Kokoro. I restarted the checks, and if they fail again for the same reason, I will submit the workaround from another branch in a new PR. Edit: The failure did not repeat, meaning that the test is flaky, but not a blocker. We can wait with the fix to be merged in #55. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88. 🦕
Test utils are now available in their own repo, meaning that we can remove the local copy of it.
PR checklist