Skip to content

chore: use 3.8 for blacken session #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 4 commits into from
May 7, 2021
Merged

chore: use 3.8 for blacken session #653

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d79a0b5
chore: use 3.8 for blacken session
busunkim96 May 6, 2021
e24d47e
chore: avoid pytype error caused by attrs==21.1.0 (#656)
plamut May 7, 2021
aa919d7
chore: use 3.8 for blacken session
busunkim96 May 6, 2021
9521cc0
Merge branch 'busunkim96-patch-3' of github.com:googleapis/python-big…
busunkim96 May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,10 @@ def unit_noextras(session):
@nox.session(python=DEFAULT_PYTHON_VERSION)
def pytype(session):
"""Run type checks."""
# An indirect dependecy attrs==21.1.0 breaks the check, and installing a less
# recent version avoids the error until a possibly better fix is found.
# https://github.com/googleapis/python-bigquery/issues/655
session.install("attrs==20.3.0")
session.install("-e", ".[all]")
session.install("ipython")
session.install(PYTYPE_VERSION)
Expand Down Expand Up @@ -253,15 +257,12 @@ def lint_setup_py(session):
session.run("python", "setup.py", "check", "--restructuredtext", "--strict")


@nox.session(python="3.6")
@nox.session(python=DEFAULT_PYTHON_VERSION)
def blacken(session):
"""Run black.
Format code to uniform standard.

This currently uses Python 3.6 due to the automated Kokoro run of synthtool.
That run uses an image that doesn't have 3.6 installed. Before updating this
check the state of the `gcp_ubuntu_config` we use for that Kokoro run.
"""

session.install(BLACK_VERSION)
session.run("black", *BLACK_PATHS)

Expand Down