Skip to content

Conversation

macbre
Copy link

@macbre macbre commented Jan 27, 2021

https://pypi.org/project/pyarrow/

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@macbre macbre requested review from a team and tswast and removed request for a team January 27, 2021 15:02
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jan 27, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 27, 2021
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but in parallel I made a similar change in #488 along with a few other changes to support Python 3.9 - let's add the pyarrow version bump in that PR then.

# https://github.com/grpc/grpc/pull/15254
"grpcio >= 1.32.0, < 2.0dev",
"pyarrow >= 1.0.0, < 3.0dev",
"pyarrow >= 1.0.0, < 4.0dev",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually need pyarrow==3.0.0 to support Python 3.9, meaning that the lower bound should be bumped, too.

@plamut
Copy link
Contributor

plamut commented Jan 27, 2021

Closing as a subset of #488, but thanks nevertheless, @macbre

@plamut plamut closed this Jan 27, 2021
@macbre macbre deleted the patch-1 branch January 27, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants