Skip to content

fix: updates tests on getters to resolve coverage issues #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chalmerlowe merged 5 commits into from
Dec 4, 2024
Merged

fix: updates tests on getters to resolve coverage issues #2080

chalmerlowe merged 5 commits into from
Dec 4, 2024

Conversation

@chalmerlowe
Copy link
Collaborator

@chalmerlowe chalmerlowe commented Nov 27, 2024 •
edited
Loading

fix: updates tests on getters to resolve coverage issues for the new PANGEA objects and removes a test that is no longer used.

Covers tests in:

  • test_external_config.py
  • test_schema.py
  • test__helpers.py

@chalmerlowe chalmerlowe requested review from a team as code owners November 27, 2024 10:41
@chalmerlowe chalmerlowe requested a review from tswast November 27, 2024 10:41
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Nov 27, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 27, 2024
@chalmerlowe chalmerlowe merged commit 1fcbc09 into pangea-v1alpha Dec 4, 2024
20 checks passed
@chalmerlowe chalmerlowe deleted the feat-b358215039-correct-coverage branch December 4, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suzmue suzmue suzmue approved these changes

@tswast tswast Awaiting requested review from tswast tswast is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@chelsea-lin chelsea-lin

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chalmerlowe @suzmue @chelsea-lin