feat: Adds attributes to SchemaField #2077
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
size: m
| INTERVAL = "INTERVAL" # NOTE: not available in legacy types | ||
| RANGE = "RANGE" # NOTE: not available in legacy types | ||
| FOREIGN = "FOREIGN" # NOTE: type acts as a wrapper for data types | ||
| # not natively understood by BigQuery unless translated |
There was a problem hiding this comment.
nit: can this be indented to align with the rest of the commend above it?
There was a problem hiding this comment.
Interesting.
When you try to indent the second line, black the Python formatter kicks the starting point back to the left and aligns it under the F in Foreign.
There was a problem hiding this comment.
I moved both lines of comment above the object FOREIGN so that they both align together.
google/cloud/bigquery/enums.py
Outdated
| DATETIME = "DATETIME" | ||
| INTERVAL = "INTERVAL" # NOTE: not available in legacy types | ||
| RANGE = "RANGE" # NOTE: not available in legacy types | ||
| FOREIGN = "FOREIGN" # NOTE: type acts as a wrapper for data types |
There was a problem hiding this comment.
Is there a test that could cover using this new enum?
There was a problem hiding this comment.
I supplemented the existing test that walks through some of enums with this enum in particular.
| """Definition of the foreign data type. | ||
| Only valid for top-level schema fields (not nested fields). | ||
| If the type is FOREIGN, this field is required. |
There was a problem hiding this comment.
are there any checks for this?
There was a problem hiding this comment.
There is now. 😺 Starting around line 250.
3 participants
Adds several new attributes to
SchemaFieldand adds to the existing test suite to account for the new attributes.