feat: adds two from_api_tests: StorageDesc & SerDeInfo #2074
+69
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
the
api: bigquery
chalmerlowe
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chalmerlowe
commented
Nov 22, 2024
suzmue
approved these changes
Nov 22, 2024
| # generate via API_REPR | ||
| result = klass.from_api_repr(resource) | ||
|
|
||
| assert result.to_api_repr() == expected.to_api_repr() |
Contributor
There was a problem hiding this comment.
It feels a little strange to have this test, which is intending to test from_api_repr, instead comparing the results of to_api_repr.
Could you write a comparison that checks that the result and expected match more directly?
Contributor
There was a problem hiding this comment.
On second thought, as I noted in github.com//pull/2076 since to_api_repr is tested I think this is actually ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test to each of the test sets for:
StorageDescriptor: test_from_api_repr
SerDeInfo: test_from_api_repr