Skip to content

fix: Updates mypy and pytype annotations, etc #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chalmerlowe merged 8 commits into from
Nov 22, 2024
Merged

fix: Updates mypy and pytype annotations, etc #2072

chalmerlowe merged 8 commits into from
Nov 22, 2024

Conversation

@chalmerlowe
Copy link
Collaborator

@chalmerlowe chalmerlowe commented Nov 18, 2024

This corrects several minor errors in type annotations.

@chalmerlowe chalmerlowe requested review from a team as code owners November 18, 2024 14:52
@chalmerlowe chalmerlowe requested a review from Linchin November 18, 2024 14:52
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Nov 18, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Nov 18, 2024
@whuffman36 whuffman36 removed their assignment Nov 18, 2024
@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 19, 2024
@chalmerlowe chalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 19, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2024
@Linchin Linchin added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 19, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 20, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 20, 2024
@chalmerlowe chalmerlowe merged commit 236455c into pangea-v1alpha Nov 22, 2024
19 of 20 checks passed
@chalmerlowe chalmerlowe deleted the update-mypy-pytype branch November 22, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

@suzmue suzmue suzmue approved these changes

@Linchin Linchin Awaiting requested review from Linchin Linchin is a code owner automatically assigned from googleapis/api-bigquery

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chalmerlowe @shollyman @suzmue @Linchin @whuffman36 @yoshi-kokoro