Skip to content

fix: avoid blocking in download thread when using BQ Storage API #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tswast merged 3 commits into from
Feb 3, 2025
Merged

fix: avoid blocking in download thread when using BQ Storage API #2034

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8eebb9d
fix: avoid blocking in download thread when using BQ Storage API
kien-truong Sep 28, 2024
aaec3ce
Merge branch 'main' into fix-bq-storage-client-deadlock
chalmerlowe Nov 18, 2024
735194b
Merge branch 'main' into fix-bq-storage-client-deadlock
tswast Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions google/cloud/bigquery/_pandas_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,10 +796,15 @@ def _download_table_bqstorage_stream(
rowstream = reader.rows(session)

for page in rowstream.pages:
if download_state.done:
return
item = page_to_item(page)
worker_queue.put(item)
while True:
if download_state.done:
return
try:
worker_queue.put(item, timeout=_PROGRESS_INTERVAL)
break
except queue.Full: # pragma: NO COVER
continue


def _nowait(futures):
Expand Down