Skip to content

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jun 12, 2020

Fixes #134.

This PR assures that too new a version of the rsa dependency does not break the library's Python 2.7 compatibility.

That version is already two years old, though, and it represents a yet another reason to start dropping Python 2.7 (and 3.5) support, too.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the type: process A process-related concern. May include testing, release, or the like. label Jun 12, 2020
@plamut plamut requested a review from shollyman June 12, 2020 18:44
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 12, 2020
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2020
@plamut
Copy link
Contributor Author

plamut commented Jun 12, 2020

AttributeError: module 'virtualenv.activation.python' has no attribute 'PestythonActivator'

I'm not sure what that is, happens when commands in virtualenvs are run, hopefully a restart will make the CI checks green again.

Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Peter!

@shollyman
Copy link
Contributor

bad day for python releases. looks like the new breakage here is in virtualenv

@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 15, 2020
@HemangChothani
Copy link
Contributor

@plamut This issue has been handled in google-auth library as you can see here, is this change still needed.

@plamut
Copy link
Contributor Author

plamut commented Jun 15, 2020

@HemangChothani Thanks for the update!

In theory the change should not be needed, just a version bump of the auth library, but I'm not 100% sure pip resolves always determines the matching versions correctly (the resolver is currently being rewritten AFAIK).

I would thus play it safe and be explicit about this, but I will borrow the fix from auth, which only restricts the RSA version for Python 2, while keeping it up to date in Python 3.

@plamut plamut requested a review from shollyman June 15, 2020 08:48
@plamut plamut merged commit de9998f into googleapis:master Jun 16, 2020
@plamut plamut deleted the iss-134 branch June 16, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A new release of rsa dependency breaks Python 2.7 tests
5 participants