-
Notifications
You must be signed in to change notification settings - Fork 323
chore: restrict rsa
version to <=4.0 for Python 2.7 compatibility
#135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not sure what that is, happens when commands in virtualenvs are run, hopefully a restart will make the CI checks green again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Peter!
bad day for python releases. looks like the new breakage here is in virtualenv |
@HemangChothani Thanks for the update! In theory the change should not be needed, just a version bump of the I would thus play it safe and be explicit about this, but I will borrow the fix from |
Fixes #134.
This PR assures that too new a version of the
rsa
dependency does not break the library's Python 2.7 compatibility.That version is already two years old, though, and it represents a yet another reason to start dropping Python 2.7 (and 3.5) support, too.
PR checklist