-
Notifications
You must be signed in to change notification settings - Fork 322
Closed
Labels
api: bigqueryIssues related to the googleapis/python-bigquery API.Issues related to the googleapis/python-bigquery API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Description
I notice that the v1beta1 API is still used.
python-bigquery/google/cloud/bigquery/_pandas_helpers.py
Lines 577 to 587 in 952164b
| def _download_table_bqstorage_stream( | |
| download_state, bqstorage_client, session, stream, worker_queue, page_to_item | |
| ): | |
| position = bigquery_storage_v1beta1.types.StreamPosition(stream=stream) | |
| rowstream = bqstorage_client.read_rows(position).rows(session) | |
| for page in rowstream.pages: | |
| if download_state.done: | |
| return | |
| item = page_to_item(page) | |
| worker_queue.put(item) |
This is good, as it keeps packages such as pandas-gbq from breaking, but shouldn't we start thinking about migrating folks to the v1 endpoint? To do that without causing too much disruption, the to_dataframe, magics, and DB-API integrations should accept either v1beta1 or v1 clients for an extended period of time.
Metadata
Metadata
Assignees
Labels
api: bigqueryIssues related to the googleapis/python-bigquery API.Issues related to the googleapis/python-bigquery API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.