Skip to content

deps: drop Python 3.5 and 3.6 #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 22 additions & 30 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,30 +1,34 @@
version: 2
jobs:
# Pip
"pip-3.5":
"lint":
docker:
- image: thekevjames/nox
environment:
# Resolve "Python 3 was configured to use ASCII as encoding for the environment"
LC_ALL: C.UTF-8
LANG: C.UTF-8
steps:
- checkout
- run: ci/config_auth.sh
- run: nox -s unit-3.5 system-3.5

"pip-3.6":
- run: nox -s lint
"docs-presubmit":
docker:
- image: thekevjames/nox
environment:
# Resolve "Python 3 was configured to use ASCII as encoding for the environment"
LC_ALL: C.UTF-8
LANG: C.UTF-8
steps:
- checkout
- run: ci/config_auth.sh
- run: nox -s unit-3.6
- run: nox -s docs

# Pip
"pip-3.7":
docker:
- image: thekevjames/nox
steps:
- checkout
- run: ci/config_auth.sh
- run: nox -s unit-3.7

"pip-3.8":
docker:
- image: thekevjames/nox
Expand All @@ -33,33 +37,22 @@ jobs:
- run: ci/config_auth.sh
- run: nox -s unit-3.8 system-3.8 cover

"lint":
docker:
- image: thekevjames/nox
environment:
# Resolve "Python 3 was configured to use ASCII as encoding for the environment"
LC_ALL: C.UTF-8
LANG: C.UTF-8
steps:
- checkout
- run: nox -s lint

# Conda
"conda-3.6-0.20.1":
"conda-3.7":
docker:
- image: continuumio/miniconda3
environment:
PYTHON: "3.6"
PANDAS: "0.20.1"
PYTHON: "3.7"
PANDAS: "0.23.2"
steps:
- checkout
- run: ci/config_auth.sh
- run: ci/run_conda.sh
"conda-3.8-NIGHTLY":
"conda-3.9-NIGHTLY":
docker:
- image: continuumio/miniconda3
environment:
PYTHON: "3.8"
PYTHON: "3.9"
PANDAS: "NIGHTLY"
steps:
- checkout
Expand All @@ -70,10 +63,9 @@ workflows:
version: 2
build:
jobs:
- "pip-3.5"
- "pip-3.6"
- lint
- docs-presubmit
- "pip-3.7"
- "pip-3.8"
- lint
- "conda-3.6-0.20.1"
- "conda-3.8-NIGHTLY"
- "conda-3.7"
- "conda-3.9-NIGHTLY"
6 changes: 0 additions & 6 deletions ci/constraints-3.5.pip

This file was deleted.

3 changes: 0 additions & 3 deletions ci/constraints-3.6.pip

This file was deleted.

11 changes: 8 additions & 3 deletions ci/constraints-3.7.pip
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
pandas==0.24.0
google-cloud-bigquery==1.12.0
pydata-google-auth==0.1.2
numpy==1.14.5
pandas==0.23.2
google-auth==1.4.1
google-auth-oauthlib==0.0.1
google-cloud-bigquery==1.11.1
google-cloud-bigquery[bqstorage,pandas]==1.11.1
pydata-google-auth==0.1.2
tqdm==4.23.0
2 changes: 1 addition & 1 deletion ci/constraints-3.8.pip
Original file line number Diff line number Diff line change
@@ -1 +1 @@
pandas
numpy==1.17.5
2 changes: 2 additions & 0 deletions ci/constraints-3.9.pip
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
numpy==1.19.4
pandas==1.1.4
File renamed without changes.
File renamed without changes.
5 changes: 5 additions & 0 deletions docs/source/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ Features
client project. Specify the target table ID as ``project.dataset.table`` to
use this feature. (:issue:`321`, :issue:`347`)

Dependencies
~~~~~~~~~~~~

- Drop support for Python 3.5 and 3.6. (:issue:`337`)


.. _changelog-0.14.1:

Expand Down
13 changes: 6 additions & 7 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,18 @@
import nox


supported_pythons = ["3.5", "3.6", "3.7", "3.8"]
system_test_pythons = ["3.5", "3.8"]
supported_pythons = ["3.7", "3.8"]
system_test_pythons = ["3.7", "3.8"]
latest_python = "3.8"

# Use a consistent version of black so CI is deterministic.
# Should match Stickler: https://stickler-ci.com/docs#black
black_package = "black==20.8b1"


@nox.session
def lint(session, python=latest_python):
@nox.session(python=latest_python)
def lint(session):
session.install(black_package, "flake8")
session.install("-e", ".")
session.run("flake8", "pandas_gbq")
session.run("flake8", "tests")
session.run("black", "--check", ".")
Expand Down Expand Up @@ -57,8 +56,8 @@ def unit(session):
)


@nox.session
def cover(session, python=latest_python):
@nox.session(python=latest_python)
def cover(session):
session.install("coverage", "pytest-cov")
session.run("coverage", "report", "--show-missing", "--fail-under=73")
session.run("coverage", "erase")
Expand Down
7 changes: 3 additions & 4 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def readme():

INSTALL_REQUIRES = [
"setuptools",
"pandas>=0.20.1",
"pandas>=0.23.2",
"pydata-google-auth",
"google-auth",
"google-auth-oauthlib",
Expand All @@ -44,16 +44,15 @@ def readme():
"Operating System :: OS Independent",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Topic :: Scientific/Engineering",
],
keywords="data",
install_requires=INSTALL_REQUIRES,
extras_require=extras,
python_requires=">=3.5",
python_requires=">=3.7",
packages=find_packages(exclude=["contrib", "docs", "tests*"]),
test_suite="tests",
)