Skip to content

deps: make graph features compatible with spanner-graph-notebook >= 1.1.7 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 4, 2025
Merged

deps: make graph features compatible with spanner-graph-notebook >= 1.1.7 #131

merged 5 commits into from
Aug 4, 2025

Conversation

@ericfe-google
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-magics API. labels Aug 1, 2025
@ericfe-google ericfe-google marked this pull request as ready for review August 1, 2025 23:40
@ericfe-google ericfe-google requested review from a team as code owners August 1, 2025 23:40
tswast
tswast approved these changes Aug 4, 2025
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast tswast changed the title chore: Fix the convert_graph_data() function to work with the latest changes to the get_nodes_edges() function in the spanner-graph-notebook repo. deps: make graph features compatible with spanner-graph-notebook >= 1.1.7 Aug 4, 2025
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2025
@tswast tswast enabled auto-merge (squash) August 4, 2025 15:46
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2025
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2025
@tswast
Copy link
Collaborator

tswast commented Aug 4, 2025

We can ignore 3.7 and 3.8 tests, as we have dropped support for those Python versions. I don't know why 3.9 is failing, though. There is no log file.

@tswast tswast merged commit f6f6d70 into main Aug 4, 2025
22 of 23 checks passed
@tswast tswast deleted the fix branch August 4, 2025 16:34
@release-please release-please bot mentioned this pull request Jul 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@agrawal-siddharth agrawal-siddharth Awaiting requested review from agrawal-siddharth agrawal-siddharth is a code owner automatically assigned from googleapis/api-bigquery

@jialuoo jialuoo Awaiting requested review from jialuoo jialuoo is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@shobsi shobsi

Labels

api: bigquery Issues related to the googleapis/python-bigquery-magics API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ericfe-google @tswast @shobsi @yoshi-kokoro