-
Notifications
You must be signed in to change notification settings - Fork 3
deps: drop support for Python 3.7 and 3.8 #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@GarrettWu I believe this is now ready for review. Mind taking a look? Edit: Python 3.7 and 3.8 test failures are expected. I have cl/780163517 ready to go to stop running these tests, to merge alongside this PR. |
|
||
- The feature must work fully on the following CPython versions: | ||
3.7, 3.8, 3.9, 3.11, 3.12 and 3.13 on both UNIX and Windows. | ||
3.9, 3.11, 3.12 and 3.13 on both UNIX and Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering why version 3.10 is omitted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's derived from which ones we unit test against.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕