Skip to content

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Jul 7, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswast tswast requested review from a team as code owners July 7, 2025 17:08
@tswast tswast requested review from whuffman36 and shobsi July 7, 2025 17:08
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-magics API. labels Jul 7, 2025
@tswast tswast added owlbot:run Add this label to trigger the Owlbot post processor. and removed api: bigquery Issues related to the googleapis/python-bigquery-magics API. labels Jul 7, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2025
@tswast tswast added owlbot:run Add this label to trigger the Owlbot post processor. api: bigquery Issues related to the googleapis/python-bigquery-magics API. labels Jul 7, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2025
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2025
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 7, 2025
@tswast tswast requested review from GarrettWu and removed request for shobsi July 7, 2025 18:53
@tswast
Copy link
Collaborator Author

tswast commented Jul 7, 2025

@GarrettWu I believe this is now ready for review. Mind taking a look?

Edit: Python 3.7 and 3.8 test failures are expected. I have cl/780163517 ready to go to stop running these tests, to merge alongside this PR.


- The feature must work fully on the following CPython versions:
3.7, 3.8, 3.9, 3.11, 3.12 and 3.13 on both UNIX and Windows.
3.9, 3.11, 3.12 and 3.13 on both UNIX and Windows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why version 3.10 is omitted

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's derived from which ones we unit test against.

@tswast tswast enabled auto-merge (squash) July 10, 2025 18:21
@tswast tswast disabled auto-merge July 10, 2025 18:21
@tswast tswast merged commit 2a8e9de into main Jul 10, 2025
22 of 25 checks passed
@tswast tswast deleted the tswast-3-8 branch July 10, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-magics API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants