refactor: Move ibis type mappings to compile module #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
TrevorBergeron
force-pushed
the
dtypes_refactor
branch
from
c38aea2 to
68017ce
Compare
TrevorBergeron
force-pushed
the
dtypes_refactor
branch
from
cefabcd to
caf1e50
Compare
junyazhang
approved these changes
Jun 6, 2024
| left_type = bigframes.dtypes.ibis_dtype_to_bigframes_dtype(x.type()) | ||
| right_type = bigframes.dtypes.ibis_dtype_to_bigframes_dtype(y.type()) | ||
| raise TypeError( | ||
| f"Cannot add {repr(left_type)} and {repr(right_type)}. {constants.FEEDBACK_LINK}" |
There was a problem hiding this comment.
Since we are removing the try except block here, shall we add the FEEDBACK_LINK to https://github.com/googleapis/python-bigquery-dataframes/blob/93353c368f6af5ae 186493137616bf562d890118/bigframes/operations/init.py#L629?
There was a problem hiding this comment.
So far the pattern has been to give feedback link when we have missing features or bugs, not for user error. I would consider this to be a user error, as it would be caused by users trying to add two incompatible types. Maybe we should just always provide feedback error though, just in case the users think its a feature gap?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕