Skip to content

feat: support ml.SimpleImputer in bigframes #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 22, 2024
Merged

feat: support ml.SimpleImputer in bigframes #708

merged 4 commits into from
May 22, 2024

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal #<341107491> 🦕

@ashleyxuu ashleyxuu requested a review from GarrettWu May 20, 2024 17:35
@ashleyxuu ashleyxuu requested review from a team as code owners May 20, 2024 17:35
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 20, 2024
GarrettWu
GarrettWu reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@GarrettWu GarrettWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz also add tests in pipeline.

@ashleyxuu ashleyxuu changed the title feat: support ml.Imputer in bigframes feat: support ml.SimpleImputer in bigframes May 20, 2024
GarrettWu
GarrettWu reviewed May 21, 2024
View reviewed changes
@GarrettWu
Copy link
Contributor

Plz also add tests in pipeline.

Hello?

@ashleyxuu ashleyxuu force-pushed the ashleyxu-ml-imputer branch from 156375a to b2410de Compare May 21, 2024 22:00
@ashleyxuu ashleyxuu force-pushed the ashleyxu-ml-imputer branch from b2410de to aa7b7b0 Compare May 21, 2024 22:42
GarrettWu
GarrettWu reviewed May 21, 2024
View reviewed changes
@ashleyxuu ashleyxuu merged commit 4c4415f into main May 22, 2024
@ashleyxuu ashleyxuu deleted the ashleyxu-ml-imputer branch May 22, 2024 01:31
@release-please release-please bot mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

Assignees

@tswast tswast

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashleyxuu @GarrettWu @tswast