Skip to content

fix: fix error in Series.drop(0) #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 4, 2024
Merged

fix: fix error in Series.drop(0) #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c3a1b5
fix: fix error in
milkshakeiii Apr 4, 2024
9f5469b
fix typo
milkshakeiii Apr 4, 2024
af350f1
improve error in edge case (match pandas)
milkshakeiii Apr 4, 2024
3d61afc
fix spelling
milkshakeiii Apr 4, 2024
5ca0c00
Merge branch 'main' into b329283168-drop-on-bool
milkshakeiii Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions bigframes/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,9 +351,11 @@ def drop(
columns: Union[blocks.Label, typing.Iterable[blocks.Label]] = None,
level: typing.Optional[LevelType] = None,
) -> Series:
if labels and index:
raise ValueError("Must specify exacly one of 'labels' or 'index'")
index = labels or index
if (labels is None) == (index is None):
raise ValueError("Must specify exactly one of 'labels' or 'index'")

if labels is not None:
index = labels

# ignore axis, columns params
block = self._block
Expand Down
14 changes: 10 additions & 4 deletions tests/system/small/test_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1529,10 +1529,16 @@ def test_groupby_window_ops(scalars_df_index, scalars_pandas_df_index, operator)
)


def test_drop_label(scalars_df_index, scalars_pandas_df_index):
col_name = "int64_col"
bf_series = scalars_df_index[col_name].drop(1).to_pandas()
pd_series = scalars_pandas_df_index[col_name].drop(1)
@pytest.mark.parametrize(
("label", "col_name"),
[
(0, "bool_col"),
(1, "int64_col"),
],
)
def test_drop_label(scalars_df_index, scalars_pandas_df_index, label, col_name):
bf_series = scalars_df_index[col_name].drop(label).to_pandas()
pd_series = scalars_pandas_df_index[col_name].drop(label)
pd.testing.assert_series_equal(
pd_series,
bf_series,
Expand Down