refactor: Add type constraints to internal op definitions. #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
TrevorBergeron
force-pushed
the
op_constraints
branch
from
aff572d to
8b762e0
Compare
TrevorBergeron
force-pushed
the
op_constraints
branch
from
8b762e0 to
6f27225
Compare
chelsea-lin
requested changes
Mar 27, 2024
bigframes/operations/type.py
Outdated
|
|
||
|
|
||
| @dataclasses.dataclass | ||
| class Fixed(OpTypeRule): | ||
| out_type: ExpressionType | ||
| class Numeric(BinaryTypeSignature): |
There was a problem hiding this comment.
BinaryNumeric? Why we have both this and BinaryRealNumeric?
There was a problem hiding this comment.
The difference is whether integer inputs result in integer output for a float output. Some operations, such as logarithm, will produce float result even if input is an integer eg log(3) ~= 0.47712. Other operations, such as abs, preserve int type eg abs(-2) == 2
| pa_result_type = pa_struct_t[self.name_or_index].type | ||
| input_type = input_types[0] | ||
| if not isinstance(input_type, pd.ArrowDtype): | ||
| raise TypeError("field accessor input must be a struct type") |
There was a problem hiding this comment.
this is for structs
chelsea-lin
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕