Skip to content

deps: fix missing CTEs in sqlglot v28 and relax version dependency #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TrevorBergeron merged 2 commits into from
Nov 20, 2025
Merged

deps: fix missing CTEs in sqlglot v28 and relax version dependency #2277

TrevorBergeron merged 2 commits into from
Nov 20, 2025

Conversation

@chelsea-lin
Copy link
Contributor

@chelsea-lin chelsea-lin commented Nov 18, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 18, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_fixsqlglot branch from 3f86dd0 to df1ebaf Compare November 18, 2025 00:34
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Nov 18, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_fixsqlglot branch from df1ebaf to 0738993 Compare November 19, 2025 22:57
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 19, 2025
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_fixsqlglot branch from 0738993 to 70c84d7 Compare November 19, 2025 23:01
@chelsea-lin chelsea-lin changed the title fix: sqlglot losses all CTE statements deps: fix missing CTEs in sqlglot v28 and relax version dependency Nov 19, 2025
@chelsea-lin chelsea-lin marked this pull request as ready for review November 19, 2025 23:09
@chelsea-lin chelsea-lin requested review from a team as code owners November 19, 2025 23:09
@TrevorBergeron TrevorBergeron merged commit e39dfe2 into main Nov 20, 2025
23 of 24 checks passed
@TrevorBergeron TrevorBergeron deleted the main_chelsealin_fixsqlglot branch November 20, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

Assignees

@TrevorBergeron TrevorBergeron

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chelsea-lin @TrevorBergeron