refactor: add agg_ops.CutOp to the sqlglot compiler #2268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
chelsea-lin
force-pushed
the
main_chelsealin_cut
branch
2 times, most recently
from
ce41321 to
65a8c11
Compare
sycai
reviewed
Nov 17, 2025
Comment on lines
231
to
256
| if op.right: | ||
| value = sge.Struct( | ||
| expressions=[ | ||
| sge.PropertyEQ( | ||
| this=sge.Identifier(this="left_exclusive", quoted=True), | ||
| expression=left, | ||
| ), | ||
| sge.PropertyEQ( | ||
| this=sge.Identifier(this="right_inclusive", quoted=True), | ||
| expression=right, | ||
| ), | ||
| ] | ||
| ) | ||
| else: | ||
| value = sge.Struct( | ||
| expressions=[ | ||
| sge.PropertyEQ( | ||
| this=sge.Identifier(this="left_inclusive", quoted=True), | ||
| expression=left, | ||
| ), | ||
| sge.PropertyEQ( | ||
| this=sge.Identifier(this="right_exclusive", quoted=True), | ||
| expression=right, | ||
| ), | ||
| ] | ||
| ) |
Contributor
There was a problem hiding this comment.
code suggestion:
if op.right:
left_identifier = sge.Identifier(this="left_exclusive", quoted=True)
right_identifier = sge.Identifier(this="right_inclusive", quoted=True)
else:
left_identifier = sge.Identifier(this="left_inclusive", quoted=True)
right_identifier = sge.Identifier(this="right_exclusive", quoted=True)
then you can construct a value with those local variables, just like what you have between line 167-172
chelsea-lin
added
the
kokoro:run
chelsea-lin
force-pushed
the
main_chelsealin_cut
branch
from
65a8c11 to
3f3328b
Compare
bigframes-bot
removed
the
kokoro:run
chelsea-lin
force-pushed
the
main_chelsealin_cut
branch
from
3f3328b to
92ad3d4
Compare
sycai
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 445774480🦕